-
Notifications
You must be signed in to change notification settings - Fork 41.4k
Use activemq-bom #41718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use activemq-bom #41718
Conversation
ActiveMQ 6.1.3 provides activemq-bom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @eddumelendez but there are two excludes there that are lost with the use of the BOM. Did you check that it isn't relevant anymore?
"activemq-broker", | ||
"activemq-client", | ||
"activemq-console" { | ||
exclude group: "commons-logging", module: "commons-logging" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check this is no longer necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @snicoll, those are still necessary. How should I proceed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the bom and then also declare the modules that require exclusions. Here's an example for Micrometer:
library("Micrometer", "1.9.17") {
considerSnapshots()
group("io.micrometer") {
modules = [
"micrometer-registry-stackdriver" {
exclude group: "javax.annotation", module: "javax.annotation-api"
}
]
imports = [
"micrometer-bom"
]
}
}
This uses micrometer-bom
while also adding an exclusion to the micrometer-registry-stackdriver
dependency that it manages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
"activemq-runtime-config", | ||
"activemq-shiro", | ||
"activemq-spring" { | ||
exclude group: "commons-logging", module: "commons-logging" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
PR has been updated |
ActiveMQ 6.1.3 provides activemq-bom. See gh-41718
Thanks very much, @eddumelendez. |
ActiveMQ 6.1.3 provides activemq-bom.