Skip to content

Use activemq-bom #41718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

eddumelendez
Copy link
Contributor

ActiveMQ 6.1.3 provides activemq-bom.

ActiveMQ 6.1.3 provides activemq-bom.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 8, 2024
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @eddumelendez but there are two excludes there that are lost with the use of the BOM. Did you check that it isn't relevant anymore?

"activemq-broker",
"activemq-client",
"activemq-console" {
exclude group: "commons-logging", module: "commons-logging"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check this is no longer necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @snicoll, those are still necessary. How should I proceed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the bom and then also declare the modules that require exclusions. Here's an example for Micrometer:

	library("Micrometer", "1.9.17") {
		considerSnapshots()
		group("io.micrometer") {
			modules = [
				"micrometer-registry-stackdriver" {
					exclude group: "javax.annotation", module: "javax.annotation-api"
				}
			]
			imports = [
				"micrometer-bom"
			]
		}
	}

This uses micrometer-bom while also adding an exclusion to the micrometer-registry-stackdriver dependency that it manages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

"activemq-runtime-config",
"activemq-shiro",
"activemq-spring" {
exclude group: "commons-logging", module: "commons-logging"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Aug 8, 2024
@eddumelendez
Copy link
Contributor Author

PR has been updated

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 13, 2024
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Aug 15, 2024
@wilkinsona wilkinsona added this to the 3.3.x milestone Aug 15, 2024
@wilkinsona wilkinsona self-assigned this Aug 15, 2024
@wilkinsona wilkinsona mentioned this pull request Aug 15, 2024
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.3 Aug 15, 2024
wilkinsona pushed a commit that referenced this pull request Aug 15, 2024
ActiveMQ 6.1.3 provides activemq-bom.

See gh-41718
@wilkinsona
Copy link
Member

Thanks very much, @eddumelendez.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants